Repository navigation
Conversation
The Bestie button read only the agent definition's picture. On a device where the agent isn't local, that inventory row has no picture, so the button fell back to initials while DM rows and messages showed the profile picture. Prefer the published profile picture, use the definition's art only until the profile loads, and keep the bundled poster match on whichever URL wins.
Contributor
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
brow
marked this pull request as ready for review
November 12, 2026 23:57
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Bestie button in the app dock and sidebar showed the agent's initial instead of its picture for some people, even though the same agent's DM row, messages and profile showed the picture.
The button read only the picture from the agent inventory. On a device where the Bestie isn't a local agent (for example an agent that runs on your other Mac), that inventory row comes from the relay library, which carries no picture of its own, so the button fell back to initials.
The button now follows the same rule as DM rows and message avatars: the agent's published profile picture wins. The inventory picture is used only until that profile loads (or when the profile has no picture, matching the channel member avatars). The bundled-poster match still runs on whichever URL wins, so pack avatars keep their offline poster.
Before (Bestie tab shows "S" for an agent whose profile has a pack avatar):
Regressions
None expected. The only new work is one background profile read for a single pubkey, through the shared profile directory that DM rows already use, so it's normally a cache hit. Agents without a profile picture keep today's behavior.
Validation
src/app/shelltests and the TypeScript typecheck pass.